[Erp5-dev] [PATCH] Problems with importing by CSV (Base_importCsvLine)

[Łukasz Nowak]

Hello,

Tomasz Brzezina send in erp5-users[1] problem report for CSV importing.
This patch is based on his suggestions.

Bye,
Luke
[1]http://thread.gmane.org/gmane.comp.python.zope.erp5.general/592/focus=597
--
?ukasz Nowak R&D Ventis http://www.ventis.com.pl/
tel: [phone] int 37 fax: [phone]
https://ssl.ventis.com.pl/keys/lukasz.nowak.pub.asc
``Use the Source, Luke...''
-------------- next part --------------
A non-text attachment was scrubbed...
Name: Base_importCsvLine.xml.patch
Type: text/x-patch
Size: 1436 bytes
Desc: not available
URL: <http://mail.tiolive.com/pipermail/erp5-dev/attachments/20061130/be8cbdd7/attachment.bin>

[Yoshinori Okuji]

Post by Łukasz Nowak
Tomasz Brzezina send in erp5-users[1] problem report for CSV importing.
This patch is based on his suggestions.

Isn't it better to use:

uid = object_property_dict.get('uid')
if uid is None:
...

YO

[Tomasz Brzezina]

Post by Yoshinori Okuji

Post by Łukasz Nowak
Tomasz Brzezina send in erp5-users[1] problem report for CSV importing.
This patch is based on his suggestions.

uid = object_property_dict.get('uid')
...

No, because we don't need uid at all. We only need to know if there is
uid or there is not. And if there is we connect to that object. If not -
we create a new object.