[Erp5-dev] Initial review of contributions

[Jean-Paul Smets]

Hi,

I read this:
http://sourceforge.net/apps/trac/addons-erp5/wiki/PatchsetContents

Thanks for documenting the patches.

There are quite a few improvements I would like to integrate to core
after careful review. I am sure some of these (not all) would already be
in the core if submitted to the ML (I remember only one which was 2
years ago).


ui_relation_field_single
<http://sourceforge.net/apps/trac/addons-erp5/wiki/PatchsetContents#ui_relation_field_single>

-> Maybe. More review needed.


improved_status_message ?
<http://sourceforge.net/apps/trac/addons-erp5/wiki/PatchsetContents#improved_status_message>

-> Maybe. More review needed.


boxover ?
<http://sourceforge.net/apps/trac/addons-erp5/wiki/PatchsetContents#boxover>

-> Yes for idea. Implementation review needed in the context of
listbox code unification and replacement of current KM popup menu.
Selenium tests required.


parallel_list_field_js ?
<http://sourceforge.net/apps/trac/addons-erp5/wiki/PatchsetContents#parallel_list_field_js>

-> Yes for idea. Implementation review needed. Selenium tests required.


sorting_parallel_list_hash_script
<http://sourceforge.net/apps/trac/addons-erp5/wiki/PatchsetContents#sorting_parallel_list_hash_script>

-> No idea yet (I do not understand purpose)


always_init_script ?
<http://sourceforge.net/apps/trac/addons-erp5/wiki/PatchsetContents#always_init_script>

-> Probably not. What is the problem of redefining portal type init
scipt method ? If it is a business template feature missing, then better
to improve business templates.


person_get_title_cleanup ?
<http://sourceforge.net/apps/trac/addons-erp5/wiki/PatchsetContents#person_get_title_cleanup>

-> Maybe. Must be studied in context of non-European localization,
which adds many other issues related to sorting and searching in
multiple languages of something which can be represented in different ways.


enable_redirect_from_base_edit ?
<http://sourceforge.net/apps/trac/addons-erp5/wiki/PatchsetContents#enable_redirect_from_base_edit>

-> Probably not. To me it fills like either doing what workflow does
or or what fast input is meant for, and makes form behaviour less
consistent overall. Fast input forms are the place to do such "wizard"
like forms.


save_and_process_button ?
<http://sourceforge.net/apps/trac/addons-erp5/wiki/PatchsetContents#save_and_process_button>

-> Probably not. To me it fills like doing what fast input is meant
for at module level and makes form behaviour less consistent overall.


switching_object_tabs_ajax ?
<http://sourceforge.net/apps/trac/addons-erp5/wiki/PatchsetContents#switching_object_tabs_ajax>

-> Yes for idea. Implementation review needed. Selenium tests required.


relation_string_field_popup ?
<http://sourceforge.net/apps/trac/addons-erp5/wiki/PatchsetContents#relation_string_field_popup>

-> Yes for idea. Implementation review needed. Selenium tests required.

Overall, some howto seems required for fast input forms, which are
essential to help people entering data faster in the context of their
specific business.

Some other hints to get your patch integrated:
- announce your patch on erp5-dev ML (not erp5-users)
- write a test (selenium tests for widgets, unit tests for features)
- provide agreement to migrate to GPLv3 licensing (recommended by FSF)

Please also keep in mind that some features which are great for you in
the context of your project may actually be catastrophic for ten other
big users and may require much for work to reach a generic solution
acceptable to everyone (ex. person_get_title_cleanup is typical of
this). In such a case, it hurst nobody to keep your patch in
experimental repository or somewhere else.

Still, it is very good to know, because it will help improving the core.

Regards,

JPS.

[Łukasz Nowak]

Hello,

Post by Jean-Paul Smets
Hi,
http://sourceforge.net/apps/trac/addons-erp5/wiki/PatchsetContents

(...)

Post by Jean-Paul Smets
switching_object_tabs_ajax ?
<http://sourceforge.net/apps/trac/addons-erp5/wiki/PatchsetContents#switching_object_tabs_ajax>
-> Yes for idea. Implementation review needed. Selenium tests required.

I have only one issue with AJAXed web sites. Quite often those AJAX
links are not links, so open in new window nor tab do not work. It would
be good to have it considered in this case: How to send link by
chat/mail to another form?

(...)

Regards,
Luke

[Bartek Gorny]

Post by Łukasz Nowak
Hello,

Hi,
? ? http://sourceforge.net/apps/trac/addons-erp5/wiki/PatchsetContents

(...)

? ? switching_object_tabs_ajax ?
? ? <http://sourceforge.net/apps/trac/addons-erp5/wiki/PatchsetContents#switching_object_tabs_ajax>
? ? -> Yes for idea. Implementation review needed. Selenium tests required.

I have only one issue with AJAXed web sites. Quite often those AJAX
links are not links, so open in new window nor tab do not work. It would
be good to have it considered in this case: How to send link by
chat/mail to another form?

Actually, I don't think myself this one is worthwhile - I did it as an
experiment, but performance gain was almost none, while it may cause
many tricky issues related to other parts of the page (hidden fields,
form action etc). It seems to be there are many places where
ajaxification can bring much more benefit then here.

Bartek

Post by Łukasz Nowak
(...)
Regards,
Luke
_______________________________________________
Erp5-dev mailing list
Erp5-dev at erp5.org
http://mail.nexedi.com/mailman/listinfo/erp5-dev