[Erp5-dev] ERP5Site_getHelpUrl fixup and Base_getHelpUrl removal proposal

[Łukasz Nowak]

Hello,

I've attached little fixup for ERP5Site_getHelpUrl, which will eat all
appended slashes (/) to generate clean URL.

Wouldn't it be nice idea to remove Base_getHelpUrl or make it invoke
new script, if it is left for backward compatibility?

Regards,
Luke
--
?ukasz Nowak R&D Ventis http://www.ventis.com.pl/
tel: [phone] fax: [phone]
``Use the Source, Luke...''
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ERP5Site_getHelpUrl.xml.slash_removal.patch
Type: text/x-patch
Size: 1374 bytes
Desc: not available
URL: <http://mail.tiolive.com/pipermail/erp5-dev/attachments/20070720/7b95b237/attachment.bin>

[Pelletier Vincent]

Post by Łukasz Nowak
I've attached little fixup for ERP5Site_getHelpUrl, which will eat all
appended slashes (/) to generate clean URL.

Wouldn't it be better to use rstrip('/') ?

[Łukasz Nowak]

On 2007-07-23, 09:26:37

Post by Pelletier Vincent

Post by Łukasz Nowak
I've attached little fixup for ERP5Site_getHelpUrl, which will eat
all appended slashes (/) to generate clean URL.

Wouldn't it be better to use rstrip('/') ?

Yes... You know, it was Friday, the day, when simplest solution won't
come... :)

Luke