[Erp5-dev] bugfix: dramaticly increase speed upgrading through TemplateTool from repositories

[Boris Kocherov]

Hi.

drastically increase speed

cut and paste - bad technology for programming

Regards,
Boris Kocherov
-------------- next part --------------
A non-text attachment was scrubbed...
Name: bt5_upgradeing_speed.patch
Type: text/x-diff
Size: 1485 bytes
Desc: not available
URL: <http://mail.tiolive.com/pipermail/erp5-dev/attachments/20080919/cc806c63/attachment.patch>

[Vincent Pelletier]

Hi.

This fix looks strange to me:
- why moving object_list definition down "one" line ?
- why adding an "i" variable initialisation without changing the one already
present in the loop (I believe one should go away) ?

Or... Maybe it wasn't the patch you intended to send ?

I guess the copy/paste you mention are the "line.edit" calls, which would mean
that only choice_item_list would be in the big "if" block.
But I admit that even then I don't see why it would increase speed (still it's
worth doing since it increases maintainability).

[Boris Kocherov]

Hello Vincent

Post by Vincent Pelletier
Hi.
- why moving object_list definition down "one" line ?
- why adding an "i" variable initialisation without changing the one already
present in the loop (I believe one should go away) ?
Or... Maybe it wasn't the patch you intended to send ?

Big thanks you absolutely right. I lack run "hg qrefresh" command.
I send corrected version patch.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: bt5_upgradeing_speed.patch
Type: text/x-diff
Size: 2381 bytes
Desc: not available
URL: <http://mail.tiolive.com/pipermail/erp5-dev/attachments/20080919/551c1860/attachment.patch>