[Erp5-dev] [PATCH] erp5_accounting_l10n_pl small patch for Organisation_viewDetails

[Łukasz Nowak]

Hello,

- used searchFolder instead of object values
- removed id (to follow guidelines)
- cleaned up Folder_viewContentList invocation [*]

I have question for [*] - invocation of Folder_viewContentList. If for
eg. listbox is restricting its view only to some portal_types shall be
Folder_viewContentList restricted too, or shall it show all portal_types
in root object?

Bye,
Luke
--
?ukasz Nowak R&D Ventis http://www.ventis.com.pl/
tel: [phone] int 37 fax: [phone]
https://ssl.ventis.com.pl/keys/lukasz.nowak.pub.asc
``Use the Source, Luke...''
-------------- next part --------------
A non-text attachment was scrubbed...
Name: listbox-org-in-acc.patch
Type: text/x-patch
Size: 2019 bytes
Desc: not available
URL: <http://mail.tiolive.com/pipermail/erp5-dev/attachments/20061121/4d3acee0/attachment.bin>

[Jérôme Perrin]

Post by Łukasz Nowak
Hello,
- used searchFolder instead of object values
- removed id (to follow guidelines)
- cleaned up Folder_viewContentList invocation [*]

Hello
why do we need a custom Organisation_viewDetails for l10n_pl ?

Post by Łukasz Nowak
I have question for [*] - invocation of Folder_viewContentList. If for
eg. listbox is restricting its view only to some portal_types shall be
Folder_viewContentList restricted too, or shall it show all portal_types
in root object?

When you have a listbox in view mode, clicking on listbox's title should bring
you in list mode on a listbox showing the *same lines*, where you can use
list mode features (cut, copy, paste, delete etc) on the same dataset.

Today, only a few forms respect this. I don't know what others think, but
maybe we could set a TALES expression for list action in
Organisation_viewDetails/listbox, something like :
python:'list?' + modules['ZTUtils'].make_query(portal_type=[x[0] for x in
field.get_value('portal_types')])

J?rome

[bartek]

Post by Jérôme Perrin

Post by Łukasz Nowak
Hello,
- used searchFolder instead of object values
- removed id (to follow guidelines)
- cleaned up Folder_viewContentList invocation [*]

Hello
why do we need a custom Organisation_viewDetails for l10n_pl ?

Because to be able to properly fill tax forms we have to define to which
tax office a given organisation reports, and I placed this control on
Organisation_viewDetails form.

Now that you mention it, it'd be probably better to place
country-specific controls on a separate form to prevent conflicts (which
is probably what you just had in mind...).

Bartek

Post by Jérôme Perrin

Post by Łukasz Nowak
I have question for [*] - invocation of Folder_viewContentList. If for
eg. listbox is restricting its view only to some portal_types shall be
Folder_viewContentList restricted too, or shall it show all portal_types
in root object?

When you have a listbox in view mode, clicking on listbox's title should bring
you in list mode on a listbox showing the *same lines*, where you can use
list mode features (cut, copy, paste, delete etc) on the same dataset.
Today, only a few forms respect this. I don't know what others think, but
maybe we could set a TALES expression for list action in
python:'list?' + modules['ZTUtils'].make_query(portal_type=[x[0] for x in
field.get_value('portal_types')])
J?rome
_______________________________________________
Erp5-dev mailing list
Erp5-dev at erp5.org
http://erp5.org/mailman/listinfo/erp5-dev

[Jean-Paul Smets]

Post by bartek

Post by Jérôme Perrin

Post by Łukasz Nowak
Hello,
- used searchFolder instead of object values
- removed id (to follow guidelines)
- cleaned up Folder_viewContentList invocation [*]

Hello
why do we need a custom Organisation_viewDetails for l10n_pl ?

Because to be able to properly fill tax forms we have to define to which
tax office a given organisation reports, and I placed this control on
Organisation_viewDetails form.
Now that you mention it, it'd be probably better to place
country-specific controls on a separate form to prevent conflicts (which
is probably what you just had in mind...).

I do not like to put hard coded stuff in organisation. We need a generic
mechanism to associate organisation (ex. tax office) to organisations (ex.
branch office). So, I will probably request current implementation to be
removed.

The clean way is to associate the tax office in the accounting transaction
line. This way, it is possible to calculate the amoun of due tax per tax
office. And it even possible for an organisation to change its tax office
during the year or to have multiple tax offices.

Filling this property automatically can simply be a side effect of
preference selection.

JPS.

Post by bartek
Bartek

Post by Jérôme Perrin

Post by Łukasz Nowak
I have question for [*] - invocation of Folder_viewContentList. If for
eg. listbox is restricting its view only to some portal_types shall be
Folder_viewContentList restricted too, or shall it show all
portal_types in root object?

When you have a listbox in view mode, clicking on listbox's title
should bring you in list mode on a listbox showing the *same lines*,
where you can use list mode features (cut, copy, paste, delete etc) on
the same dataset.
Today, only a few forms respect this. I don't know what others think,
but maybe we could set a TALES expression for list action in
python:'list?' + modules['ZTUtils'].make_query(portal_type=[x[0] for x
in field.get_value('portal_types')])
J??rome
_______________________________________________
Erp5-dev mailing list
Erp5-dev at erp5.org
http://erp5.org/mailman/listinfo/erp5-dev

_______________________________________________
Erp5-dev mailing list
Erp5-dev at erp5.org
http://erp5.org/mailman/listinfo/erp5-dev

[bartek]

Post by Jean-Paul Smets

Post by bartek

Post by Jérôme Perrin

Post by Łukasz Nowak
Hello,
- used searchFolder instead of object values
- removed id (to follow guidelines)
- cleaned up Folder_viewContentList invocation [*]

Hello
why do we need a custom Organisation_viewDetails for l10n_pl ?

Because to be able to properly fill tax forms we have to define to which
tax office a given organisation reports, and I placed this control on
Organisation_viewDetails form.
Now that you mention it, it'd be probably better to place
country-specific controls on a separate form to prevent conflicts (which
is probably what you just had in mind...).

I do not like to put hard coded stuff in organisation. We need a generic
mechanism to associate organisation (ex. tax office) to organisations (ex.
branch office). So, I will probably request current implementation to be
removed.
The clean way is to associate the tax office in the accounting transaction
line. This way, it is possible to calculate the amoun of due tax per tax
office. And it even possible for an organisation to change its tax office
during the year or to have multiple tax offices.
Filling this property automatically can simply be a side effect of
preference selection.

So, perhaps it would be enough to put tax office to preferences, like we
do with GAP and other stuff?

BG

Post by Jean-Paul Smets
JPS.

Post by bartek
Bartek

Post by Jérôme Perrin

Post by Łukasz Nowak
I have question for [*] - invocation of Folder_viewContentList. If for
eg. listbox is restricting its view only to some portal_types shall be
Folder_viewContentList restricted too, or shall it show all
portal_types in root object?

When you have a listbox in view mode, clicking on listbox's title
should bring you in list mode on a listbox showing the *same lines*,
where you can use list mode features (cut, copy, paste, delete etc) on
the same dataset.
Today, only a few forms respect this. I don't know what others think,
but maybe we could set a TALES expression for list action in
python:'list?' + modules['ZTUtils'].make_query(portal_type=[x[0] for x
in field.get_value('portal_types')])
J??rome
_______________________________________________
Erp5-dev mailing list
Erp5-dev at erp5.org
http://erp5.org/mailman/listinfo/erp5-dev

_______________________________________________
Erp5-dev mailing list
Erp5-dev at erp5.org
http://erp5.org/mailman/listinfo/erp5-dev