Discussion:
[Erp5-dev] [Erp5-report] r27008 - /erp5/trunk/products/ERP5Type/tests/ERP5TypeTestCase.py
Sebastien Robin
2009-05-17 19:28:43 UTC
Permalink
Author: seb
Date: Sun May 17 17:02:43 2009
New Revision: 27008
URL: http://svn.erp5.org?rev=27008&view=rev
- revert commit 25467, a more "readable" dump is more than 10 times
slower to import than an optimised one, it can takes several minutes
instead of a few seconds
My box was not well configured, the difference is smaller, so optimised one
can take 1 second and the other one 3 seconds.

Regards.

S?bastien.
erp5/trunk/products/ERP5Type/tests/ERP5TypeTestCase.py
Modified: erp5/trunk/products/ERP5Type/tests/ERP5TypeTestCase.py
URL: http://svn.erp5.org/erp5/trunk/products/ERP5Type/tests/ERP5TypeTestCase.py?rev=27008&r1=27007&r2=27008&view=diff
==============================================================================
--- erp5/trunk/products/ERP5Type/tests/ERP5TypeTestCase.py [utf8] (original)
+++ erp5/trunk/products/ERP5Type/tests/ERP5TypeTestCase.py [utf8] Sun May 17 17:02:43 2009
@@ -777,7 +777,10 @@
transaction.commit()
ZopeTestCase.close(app)
instance_home = os.environ['INSTANCE_HOME']
- command = 'mysqldump --skip-extended-insert %s > %s/dump.sql' \
+ # The output of mysqldump needs to merge many lines at a time
+ # for performance reasons (merging lines is at most 10 times
+ # faster, so this produce somewhat not nice to read sql
+ command = 'mysqldump %s > %s/dump.sql' \
% (getMySQLArguments(), instance_home)
ZopeTestCase._print('Dumping MySQL database with %s... ' \
_______________________________________________
Erp5-report mailing list
Erp5-report at erp5.org
http://mail.nexedi.com/mailman/listinfo/erp5-report
Kazuhiko Shiozaki
2009-05-17 22:21:58 UTC
Permalink
Post by Sebastien Robin
Author: seb
Date: Sun May 17 17:02:43 2009
New Revision: 27008
- revert commit 25467, a more "readable" dump is more than 10 times
slower to import than an optimised one, it can takes several minutes
instead of a few seconds
My box was not well configured, the difference is smaller, so optimised one
can take 1 second and the other one 3 seconds.
Anyway, such a 'preference' should be specified by his/her own
environment like:

$ cat ~/.my.cnf
[mysqldump]
skip-extended-insert

So I have no objection to revert my old commit r.25467.
--
Kazuhiko Shiozaki, Nexedi SA Senior Consultant
Nexedi: Consulting and Development of Free / Open Source Software
http://www.nexedi.com
ERP5: Full Featured High End Open Source ERP
http://www.erp5.com
ERP5 Wiki: Developer Zone for ERP5 Community
http://www.erp5.org
Loading...