[Erp5-dev] Deleted - how to make invisible?

Discussion:

Shresth K

2007-06-26 18:21:52 UTC

Hello,

With reference to the mail
http://www.erp5.org/pipermail/erp5-dev/2006-September/000678.html

Here is the rule we are going towards after much discusion:
1- objects which are handled by workflows can not be deleted: deletion is
part of the workflow (ie. the document lifecycle) and must therefore be
implemented by a workflow action which may for example move the object to
an "archived" state (invisible)

I have managed to get the first part working and objects with workflows can
now be marked as 'Deleted'. But, where is the magic for the "archival" or
"invisible" happening? In the context of Business templates, I can see that
the objects marked as 'Deleted' are no longer visible but how and where is
the logic/code for the same, remains a mystery. Any pointers in this
direction shall be most welcome.

Thanks,
Shresth
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.tiolive.com/pipermail/erp5-dev/attachments/20070626/2e5a5246/attachment.htm>

bartek

2007-06-26 18:31:16 UTC

Permalink

Post by Shresth K
Hello,
With reference to the mail
http://www.erp5.org/pipermail/erp5-dev/2006-September/000678.html
1- objects which are handled by workflows can not be deleted: deletion is
part of the workflow (ie. the document lifecycle) and must therefore be
implemented by a workflow action which may for example move the object to
an "archived" state (invisible)
I have managed to get the first part working and objects with workflows
can now be marked as 'Deleted'. But, where is the magic for the
"archival" or "invisible" happening? In the context of Business
templates, I can see that the objects marked as 'Deleted' are no longer
visible but how and where is the logic/code for the same, remains a
mystery. Any pointers in this direction shall be most welcome.

Security - workflow in deleted state can take 'view' permissions away
from you (even from Manager), so it disappears from all listboxes.

B.

Post by Shresth K
Thanks,
Shresth
------------------------------------------------------------------------
_______________________________________________
Erp5-dev mailing list
Erp5-dev at erp5.org
http://erp5.org/mailman/listinfo/erp5-dev

--
"feelings affect productivity. (...) unhappy people write worse
software, and less of it."
Karl Fogel, "Producing Open Source Software"

Shresth K

2007-06-26 18:56:11 UTC

Permalink

Thanks. Is there a plan to modify all standard/default workflows to have the
delete_action? If yes, then I can try and submit a patch for the same.

Shresth

Post by Shresth K

Post by Shresth K
Hello,
With reference to the mail
http://www.erp5.org/pipermail/erp5-dev/2006-September/000678.html

deletion is

Post by Shresth K
part of the workflow (ie. the document lifecycle) and must therefore

Post by Shresth K
implemented by a workflow action which may for example move the

object to

Post by Shresth K
an "archived" state (invisible)
I have managed to get the first part working and objects with workflows
can now be marked as 'Deleted'. But, where is the magic for the
"archival" or "invisible" happening? In the context of Business
templates, I can see that the objects marked as 'Deleted' are no longer
visible but how and where is the logic/code for the same, remains a
mystery. Any pointers in this direction shall be most welcome.

Security - workflow in deleted state can take 'view' permissions away
from you (even from Manager), so it disappears from all listboxes.
B.

--
"feelings affect productivity. (...) unhappy people write worse
software, and less of it."
Karl Fogel, "Producing Open Source Software"
_______________________________________________
Erp5-dev mailing list
Erp5-dev at erp5.org
http://erp5.org/mailman/listinfo/erp5-dev

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.tiolive.com/pipermail/erp5-dev/attachments/20070627/53025193/attachment.htm>

Jean-Paul Smets

2007-06-27 04:51:44 UTC

Permalink

Post by Shresth K
Thanks. Is there a plan to modify all standard/default workflows to have the
delete_action? If yes, then I can try and submit a patch for the same.

Yes, there is such a plan to review all standard workflows so that they
meet all rules and guidelines.

JPS.

Post by Shresth K
Shresth

Post by Shresth K

Post by Shresth K
Hello,
With reference to the mail
http://www.erp5.org/pipermail/erp5-dev/2006-September/000678.html

deletion is

Post by Shresth K
part of the workflow (ie. the document lifecycle) and must

therefore
be

Post by Shresth K
implemented by a workflow action which may for example move the

object to

Post by Shresth K
an "archived" state (invisible)
I have managed to get the first part working and objects with

workflows

Post by Shresth K
can now be marked as 'Deleted'. But, where is the magic for the
"archival" or "invisible" happening? In the context of Business
templates, I can see that the objects marked as 'Deleted' are no

longer

Post by Shresth K
visible but how and where is the logic/code for the same, remains a
mystery. Any pointers in this direction shall be most welcome.

Security - workflow in deleted state can take 'view' permissions away
from you (even from Manager), so it disappears from all listboxes.
B.

Post by Shresth K
Thanks,
Shresth

------------------------------------------------------------------------

Post by Shresth K
_______________________________________________
Erp5-dev mailing list
Erp5-dev at erp5.org
http://erp5.org/mailman/listinfo/erp5-dev

------------------------------------------------------------------------
_______________________________________________
Erp5-dev mailing list
Erp5-dev at erp5.org
http://erp5.org/mailman/listinfo/erp5-dev

Shresth K

2007-06-27 05:07:39 UTC

Permalink

Post by Jean-Paul Smets

Post by Shresth K
Thanks. Is there a plan to modify all standard/default workflows to have the
delete_action? If yes, then I can try and submit a patch for the same.

Yes, there is such a plan to review all standard workflows so that they
meet all rules and guidelines.

What other 'rules and guidelines' should be taken care of in the review
process? If you may provide a pointer/link to a document/discussion then I
can try to consider the same before starting off on the patches. As of now I
am only aware of the missing delete_action.

Shresth
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.tiolive.com/pipermail/erp5-dev/attachments/20070627/41aa29ff/attachment.htm>