[Erp5-dev] ERP5Forms patches for more css awareness

[Patrick Gerken]

Hello,

attached is a patch for three files which change two things in erp5forms:
First, the listbox patches now interprets the css definition of a
field, and renders that information too.
It puts the content in a new span tag, so that the td css definition
can not be overwritten.

The other two patches do something similar to normal fields, currently
a read only text field will ignore css definitions.
This patch changes the api of the render_htmlgrid method. It still
returns a tuple, but with some more values. The old values are still
in its original place, and if you don't do something strange like
negative index numbers it should not break existing page templates.
Actually there were changes needed on the portal_skins too, but I am
not sure, what the preferred way might be to submit patches for these.
First I changed the erp5.css and made the error class more generic, it
is not td.error but .error now (All out of my head, since I can't be
online and access our system :-( ). Then of course all page templates
which use render_htmlgrid needed to be modified to really show the
css. It seems that our page templates are very different already to
the erp5 default ones, so I can not describe exactly what has changed.
All these changes are necessary for something I tend to call
persistent error message, which I will try to document in the wiki in
the next days.

Patrick
-------------- next part --------------
A non-text attachment was scrubbed...
Name: listbox_css_change.patch
Type: text/x-diff
Size: 6464 bytes
Desc: not available
URL: <http://mail.tiolive.com/pipermail/erp5-dev/attachments/20060307/6937fb93/attachment.patch>

[Jean-Paul Smets]

Post by Patrick Gerken
Hello,

Thank you very much for the patches. I will read carefully and get back to
you.

Post by Patrick Gerken
First, the listbox patches now interprets the css definition of a
field, and renders that information too.
It puts the content in a new span tag, so that the td css definition
can not be overwritten.
The other two patches do something similar to normal fields, currently
a read only text field will ignore css definitions.
This patch changes the api of the render_htmlgrid method. It still
returns a tuple, but with some more values. The old values are still
in its original place, and if you don't do something strange like
negative index numbers it should not break existing page templates.
Actually there were changes needed on the portal_skins too, but I am
not sure, what the preferred way might be to submit patches for these.
First I changed the erp5.css and made the error class more generic, it
is not td.error but .error now (All out of my head, since I can't be
online and access our system :-( ). Then of course all page templates
which use render_htmlgrid needed to be modified to really show the
css. It seems that our page templates are very different already to
the erp5 default ones, so I can not describe exactly what has changed.
All these changes are necessary for something I tend to call
persistent error message, which I will try to document in the wiki in
the next days.
Patrick