[Erp5-dev] SaleOrder_applySaleTradeCondition - is coping ok?

[Łukasz Nowak]

Hello,

In SaleOrder_applySaleTradeCondition there is coping of Payment
Condition from STC to SO. But I was instructed to not to allow copy&move
for ordinary users. In our case sale clerk is using Trade Conditions, so
I'd like to know what's more Nexedish: to rewrite
SaleOrder_applySaleTradeCondition w/o coping or to give ordinary users
copy&move rights?

Thanks,
Luke

[Jérôme Perrin]

But I was instructed to not to allow copy&move for ordinary users

You can allow copy or move on a module when you know that copy & paste of
documents in the module have no side effects (it have side effects, for
example, if you copy a reference that is supposed to be generated when the
document is validated, or if you copy a relation to another object on which
related documents is important -remember all properties are blindly copied).

Anyway, you just have to identify those side effects, and to fix them (if any)
in a ${PortalType}_afterClone script that is automatically called on the
copied object, then you can allow copy or move on the module. Copy and paste
is something end users usually appreciate a lot.

J?rome